Spent time

14.02.2022 12:10

14.02.2022

Development

Support #840: Don't update borrowernumber if old illrequest exists

This was one of the tasks that we requested more information for. Reading Magnus's response to it and looking at the code. It seems we should override $borrower with the pre-existing borrower found in illrequests.borrowernumber if an old illrequests exists. Implementing this and sending a PR to upstream.

0.75

Actions

Koha Contributions

22.02.2022 14:27

22.02.2022

Week
Author
Tracker
Parent task
Status
Category
Target version
Non-billable hours
Lisälaskutettavaa
Owner
Message-ID
Sponsored-by
Koha Bugzilla Bug#
PV - tietokanta

Project
Created
Date
User
Activity
Issue
Comment
Hours

Columns	Available Columns Selected Columns
Group results by
Totals	Hours

Project	Created	Date	User	Activity	Issue	Comment	Hours
Koha Contributions	14.02.2022 12:10	14.02.2022	Lari Taskula	Development	Support #840: Don't update borrowernumber if old illrequest exists	This was one of the tasks that we requested more information for. Reading Magnus's response to it and looking at the code. It seems we should override $borrower with the pre-existing borrower found in illrequests.borrowernumber if an old illrequests exists. Implementing this and sending a PR to upstream.	0.75	Actions
Koha Contributions	22.02.2022 14:27	22.02.2022	Lari Taskula	Development	Support #762: Edit patron information before registration of arrival	Reading an email from Magnus. He had reported a bug on Bug 22321 that I had forgotten. Creating an unit test to cover the bug and implementing a fix. Pushing patches to Bugzilla and reporting back to Magnus.	0.75	Actions
Koha Contributions	18.10.2022 23:03	19.10.2022	Lari Taskula	Development	Feature #942: Change item level hold to biblio level hold	Implementing a select dropdown as suggested by a patch tester. Also found a bug in old patches so fixing those.	0.75	Actions
Koha Contributions	03.11.2022 20:53	03.11.2022	Lari Taskula	Development	Feature #942: Change item level hold to biblio level hold	QA failed because patch didn't handle reserves.item_level_hold column. Implementing a fix and unit tests for it, attaching patch to Bugzilla.	0.75	Actions
Development	05.05.2020 15:49	05.05.2020	Lari Taskula	Communication	Support #276: Test::DBIx::Class::Factory	Emailing the author. Asking them to publish the project in GitHub. They agreed.	0.75	Actions
Koha Contributions	07.09.2021 21:34	08.09.2021	Lari Taskula	Design	Feature #578: ansible-role-koha	Discussing Koha ansible with kivilahtio. Studying NatLibFi's implementation.	1.00	Actions
Koha Contributions	05.07.2022 14:57	15.06.2022	Lari Taskula	Design	Feature #944: Avoid changing tabs on page reload on holds awaiting pickup page	Designing feature. Looking at example from Koha's reports page, it uses cookies to store current tab.	1.00	Actions
Koha Fund	01.12.2023 17:48	01.12.2023	Lari Taskula	Design	Support #1129: Bug 35471 - Automatically select child MARC framework when adding child records	Initial work. Discussing with client. Proposing to use our Koha Fund for this.	1.00	Actions
Koha Fund	19.04.2021 15:12	19.04.2021	Lari Taskula	Development	Bug #502: Bug 28170 - Downloading some files via Tools - Upload is broken	Identifying this bug since a customer reported inability to download files. Reading jQuery DataTables documentation, creating a patch and attaching to Koha Bugzilla.	1.00	Actions
Koha Contributions	07.09.2021 21:27	08.09.2021	Lari Taskula	Development	Feature #577: Swedbank Pay	Adding order_id and a dependant Koha instance name. Koha instance name is prefixing order_id so that order_id's are unique between different Koha instances using the same Swedbank Pay interface.	1.00	Actions
Koha Contributions	29.09.2021 13:20	29.09.2021	Lari Taskula	Development	Feature #577: Swedbank Pay	Adding support for Koha 20.05 and older OPAC templates	1.00	Actions
Koha Contributions	24.01.2022 15:46	24.01.2022	Lari Taskula	Development	Support #762: Edit patron information before registration of arrival	Creating a mock Libris response so that we can start development without Libris API keys. Using a dummy response from Libris documentation. Running into configuration issues. partner_code seems to not get populated for $ill_config. It is defined in $KOHA_CONF but it looks like the code is attempting to read it from config.yaml. Debugging.	1.00	Actions
Koha Contributions	11.02.2022 13:11	11.02.2022	Lari Taskula	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	Continuing where Samu left off. Reading specification description, observing Koha's current capabilities for displaying item type, adding item type as new column, creating a new Bug, translating item type code to item type description and sending a new patch to Bugzilla.	1.00	Actions
Koha Contributions	14.02.2022 10:34	14.02.2022	Lari Taskula	Development	Feature #786: Cron script reminder for unretrieved material	Some fixes were required after Magnus's reviewing. Removed useless query, removed a statement that overrided a configuration variable that eventually led into a bug on further iterations of the reminder loop, added some print statements for better logging, and fixed a bug in array size comparison that made the lastly configured letter to be skipped.	1.00	Actions
Koha Contributions	01.03.2022 01:34	01.03.2022	Lari Taskula	Development	Support #851: Bug 30200 - Add customizable tabs to interlibrary loan requests list	Investigating current solutions for customizable tabs. Didn't find anything in system preferences. Thought of placing it in authorized values, but it wouldn't work well there. Adding a new system preference ILLRequestsTabs with a yaml config, writing short documentation for it.	1.00	Actions
Koha Contributions	06.09.2022 21:13	07.09.2022	Lari Taskula	Development	Feature #942: Change item level hold to biblio level hold	Starting to design this feature. Playing with GUI implementation and thinking of how to implement business logic. It is documented that a record cannot have mixed biblio/item level holds - all holds following the first one must be of same type. This places a big restriction on how this feature can be done. Asking client for their ideas.	1.00	Actions
Koha Fund	16.09.2022 15:44	16.09.2022	Lari Taskula	Development	Bug #965: Bug 31565 - Patron search filter by category code with special character returns no results	Implementing further fixes to exact match search regarding escape of '\' character, and attaching a patch to Bugzilla.	1.00	Actions
Koha Fund	05.10.2022 06:13	05.10.2022	Lari Taskula	Development	Support #971: Records in search results not generating a valid link due to a missing biblionumber	Fixing migration scripts.	1.00	Actions
Koha Contributions	29.11.2022 13:40	29.11.2022	Lari Taskula	Development	Support #973: Bug 18595 - Move C4::Members::Messaging to Koha namespace	Testing patches, found errors with patch "Catch message preference exceptions in OPAC", wrong exception package name, probably due to previous rebasing mistake. Fixing.	1.00	Actions
Koha Fund	13.04.2023 00:55	13.04.2023	Lari Taskula	Development	Bug #1025: KohaSuomi label printer is not clearing add_to_print_labels_list_* placeholders when adding multiple items	Implementing a fix, pushing changes to GitHub and making a new release.	1.00	Actions
Koha Contributions	03.02.2021 22:23	03.02.2021	Lari Taskula	Communication	Feature #421: Bug 20028 - Export all patron related personal data in one package	Commenting to Bugzilla. Reading DBIx documentation and writing some draft code to support my new idea of using DBIx relationships instead.	1.00	Actions
Koha Contributions	05.02.2021 18:46	05.02.2021	Lari Taskula	Communication	Bug #439: Bug 27630 - TestBuilder real number precision to use column's size	Emailing koha-devel.	1.00	Actions
Free Open Source Software Contributions	02.09.2021 12:01	02.09.2021	Lari Taskula	Communication	Feature #573: COSS partnership	Meeting COSS people in Jitsi, discussing their strategic plans, explaining our business model and discussing how COSS could help us. Very cool people!	1.00	Actions
Koha Contributions	14.09.2021 22:33	15.09.2021	Lari Taskula	Communication	Feature #577: Swedbank Pay	Replying to imCode, reading Swedbank docs for reference	1.00	Actions
Koha Contributions	06.07.2022 23:30	07.07.2022	Lari Taskula	Communication	Feature #941: Bug 22456 - Allow patrons to cancel their waiting holds	Commenting on Bugzilla about a possible scenario where patron wants to revert the cancellation request, had to inspect patches for reference.	1.00	Actions
Koha Contributions	05.10.2022 16:50	07.07.2022	Lari Taskula	Communication	Feature #940: Remove hold to a biblio if a non-holdable itemtype from the same biblio is checked out	Emailing with client, July/August	1.00	Actions
Koha Fund	23.02.2021 19:45	23.02.2021	Lari Taskula	Maintenance	Feature #462: getitem-ajax.pl error handling	Investigating error. Creating an issue on KohaSuomi GitHub. Discussing general log error handling with @kivilahtio. Deciding to use Koha Fund for such errors - it is appropriate because fixing such errors improve product quality. The end result should be notifying the client of the error, instead of crashing and logging it into Koha logs.	1.00	Actions
Koha Fund	05.10.2022 06:05	05.10.2022	Lari Taskula	Maintenance	Support #971: Records in search results not generating a valid link due to a missing biblionumber	Investigate issue, populate 999-fields with batchRepairMissingBiblionumbers.pl and document this issue in case someone else runs into it.	1.00	Actions
Koha Contributions	06.10.2022 12:07	06.10.2022	Lari Taskula	Maintenance	Support #972: Bug 17499 - Koha objects for messaging preferences	Rebasing Bug 17499 and attaching fresh patches to Bugzilla.	1.00	Actions
Koha Contributions	30.11.2022 18:24	30.11.2022	Lari Taskula	Maintenance	Support #973: Bug 18595 - Move C4::Members::Messaging to Koha namespace	Going through test plans, found a 500 error in staff client when creating a new patron and email is not set. This was in fact already reported in 18595, but I had forgotten it. Need better exception handling in staff client.	1.00	Actions
Koha Contributions	10.02.2022 01:17	10.02.2022	Lari Taskula	Learning	Support #762: Edit patron information before registration of arrival	Reading specification and trying to understand it. Browsing related views in Koha. Asking for more information.	1.00	Actions
Koha Contributions	05.07.2022 18:07	05.07.2022	Lari Taskula	Learning	Feature #940: Remove hold to a biblio if a non-holdable itemtype from the same biblio is checked out	Going through Finnish Koha libraries' documentation and finding a possible resolution to this issue that requires a change in circulation rules workflow. Instead of defining hold restriction at "Default holds policy by item type", where exissting holds will not cancel when non-holdable itemtype is checked out, to placing the hold restrction at normal circulation rules table, where the holds do cancel when checking out a non-holdable itemtype.	1.00	Actions
Koha Fund	13.12.2022 17:54	13.12.2022	Lari Taskula	Translating	Support #588: Translate Koha-Community OPAC	Investigating & fixing defaultSortField ascending/descending mistranslation.	1.00	Actions
Koha Fund	19.04.2023 01:18	19.04.2023	Lari Taskula	Translating	Support #588: Translate Koha-Community OPAC	Fixing critical errors on 22.05	1.00	Actions
Koha Contributions	04.02.2021 19:51	04.02.2021	Lari Taskula	Development	Bug #439: Bug 27630 - TestBuilder real number precision to use column's size	Found annoying issue with Bug 20028's tests when running Test::More's is_deeply comparing an object built by TestBuilder with an object fetched from database via DBIx. Decimal places do not match. Investigating TestBuilder. Found there's a hardcoded 2-decimal place definition. Creating a new Bug to Bugzilla and patching the issue.	1.25	Actions
Koha Contributions	02.02.2022 01:45	02.02.2022	Lari Taskula	Development	Support #780: Charge patron a fee at receive	Reading specification for step b. Implementing changes.	1.25	Actions
Koha Contributions	09.02.2022 23:56	10.02.2022	Lari Taskula	Development	Support #779: Bug 24239 - Let the ILL module set ad hoc hard due dates	Reading Magnus's response. Creating a configuration variable that allows configuring which field will be used for due date. Adding business logic behind it. Testing. Creating a pull request.	1.25	Actions
Koha Contributions	15.02.2022 19:48	15.02.2022	Lari Taskula	Development	Feature #786: Cron script reminder for unretrieved material	Making fixes according to Magnus's feedback. Removed faulty logic that message transport types would be based on the messages sent at receival step. Changed it so that now we attempt to find all transport types defined for that specific letter code and send notifications to all of them. Pushing changes to GitHub PR.	1.50	Actions
Koha Fund	28.03.2022 10:59	28.03.2022	Lari Taskula	Development	Support #916: Bug 30376 - Unable to save item if field date acquired is set mandatory	Client has observed the error and reported it to us. Reproducing and debugging. Identified error to 952$d. When a flatpickr field (such as 952$d aka. date acquired or dateaccessioned) is mandatory in item modification screen, form validation fails because Koha is unable to find the input field and observe its value. Creating a new Bug to Bugzilla, implementing a fix and sending the patch to BZ.	1.50	Actions
Koha Contributions	28.11.2022 22:30	29.11.2022	Lari Taskula	Development	Support #993: Bug 32357 - Set borrower_message_preferences.days_in_advance default to NULL	Investigating SetMessagingPreferences logic. It seems it overrides borrower_message_preferences.days_in_advance default (from 0 to null), so we might as well set default to null at database level. Implementing patch, figuring out how to test it, commenting on Bugzilla, attaching a patch.	1.50	Actions

Project

General

Profile

Hypernova Oy Redmine

CSV export options