Spent time

14.02.2022 11:44

14.02.2022

Development

Support #762: Edit patron information before registration of arrival

Designing this feature. It was requested that reserves.borrowernumber should also update when illrequests.borrowernumber is updated. It could be implemented in various ways, but deciding to extend Koha::Illrequest->store() with logic to replace borrowernumber also in reserves-table. Writing unit tests. Reading plenty of DBIx documentation. Figuring out how to retrieve the before-store() value of "borrowernumber" so that it could be compared with the borrowernumber used in "set" (or $illreq->borrowernumber(xxx)), but apprarently it's not possible without fetching the whole Koha-object again (or unless you somehow store it locally in the object). Managed to make it work by fetching the whole object again if borrowernumber is updated according to "get_dirty_columns". Adding an editable input field to ILL-request edit screen and writing a test plan. Pushing patches to Bugzilla.

4.50

Actions

Columns	Available Columns Selected Columns
Group results by
Totals	Hours

Project	Created	Date	User	Activity	Issue	Comment	Hours
Koha Contributions	14.02.2022 11:44	14.02.2022	Lari Taskula	Development	Support #762: Edit patron information before registration of arrival	Designing this feature. It was requested that reserves.borrowernumber should also update when illrequests.borrowernumber is updated. It could be implemented in various ways, but deciding to extend Koha::Illrequest->store() with logic to replace borrowernumber also in reserves-table. Writing unit tests. Reading plenty of DBIx documentation. Figuring out how to retrieve the before-store() value of "borrowernumber" so that it could be compared with the borrowernumber used in "set" (or $illreq->borrowernumber(xxx)), but apprarently it's not possible without fetching the whole Koha-object again (or unless you somehow store it locally in the object). Managed to make it work by fetching the whole object again if borrowernumber is updated according to "get_dirty_columns". Adding an editable input field to ILL-request edit screen and writing a test plan. Pushing patches to Bugzilla.	4.50	Actions
Koha Contributions	14.02.2022 10:34	14.02.2022	Lari Taskula	Development	Feature #786: Cron script reminder for unretrieved material	Some fixes were required after Magnus's reviewing. Removed useless query, removed a statement that overrided a configuration variable that eventually led into a bug on further iterations of the reminder loop, added some print statements for better logging, and fixed a bug in array size comparison that made the lastly configured letter to be skipped.	1.00	Actions
Koha Contributions	14.02.2022 07:47	14.02.2022	Lari Taskula	Development	Support #761: koha-illbackend-libris enhancements	Work log entry for Samu's work. Only Lari's entries (such as this) will be billed. Samu debugged a bug with the creation of new ILL request, and after receiving more information from Magnus he fixed it and sent a PR to upstream.	3.75	Actions
Koha Contributions	14.02.2022 07:41	14.02.2022	Lari Taskula	Development	Support #820: Allow renewals for ILLs	More testing and making bug fixes. Creating a new PR to upstream, ready for review.	0.75	Actions
Koha Contributions	11.02.2022 16:32	11.02.2022	Lari Taskula	Development	Support #820: Allow renewals for ILLs	Developing this feature. Studying and experimenting how ILL backend statuses behave. It seems that it's enough to create a new placeholder status "IN_UTL_RENEW" that's not an actual status, but just a placeholder to add a button to illview screen. Its actual status (stored in the database) is still "IN_UTL". Using code from the receive step and adjusting it for the needs of renewals. Testing. Pushing changes to GitHub.	3.50	Actions
Koha Contributions	11.02.2022 13:11	11.02.2022	Lari Taskula	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	Continuing where Samu left off. Reading specification description, observing Koha's current capabilities for displaying item type, adding item type as new column, creating a new Bug, translating item type code to item type description and sending a new patch to Bugzilla.	1.00	Actions
Koha Contributions	10.02.2022 06:27	10.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	Trying to figure out how to use KohaTable instead of just dataTable in Holds-tab	2.00	Actions
Koha Contributions	09.02.2022 23:56	10.02.2022	Lari Taskula	Development	Support #779: Bug 24239 - Let the ILL module set ad hoc hard due dates	Reading Magnus's response. Creating a configuration variable that allows configuring which field will be used for due date. Adding business logic behind it. Testing. Creating a pull request.	1.25	Actions
Koha Contributions	09.02.2022 23:54	10.02.2022	Lari Taskula	Development	Support #780: Charge patron a fee at receive	Noticed a bug that causes logs to get spammed by a warning. Fixing it and sending a PR.	0.50	Actions
Koha Contributions	09.02.2022 23:30	10.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	I have studied the Koha-database tables and the way to access the homebranch-information of items.	1.00	Actions
Koha Contributions	09.02.2022 22:59	10.02.2022	Lari Taskula	Development	Feature #786: Cron script reminder for unretrieved material	Making improvements according to author's feedback.	0.75	Actions
Koha Contributions	09.02.2022 01:24	09.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	Studying those javascript-files again with better understanding of the language syntax. Now I understand a whole lot better.	2.00	Actions
Koha Contributions	07.02.2022 08:06	07.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	And in fact it's not a calling object but oObj is as a parameter	0.10	Actions
Koha Contributions	07.02.2022 07:53	07.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	The main problem is that I know so little about javascript. I really have to study javascript syntax to get this to work. And, maybe the calling object in the holds-table is biblio after all, because oObj.title is a biblio name :)	1.00	Actions
Koha Contributions	07.02.2022 04:43	07.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	Ok, now I have replaced the checkouts-tab functionality temporarily with interlibrary-tab just for testing. And now changing the functionality of the interlibrary-tab towards its real purpose.	1.00	Actions
Koha Contributions	07.02.2022 03:35	07.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	Working so hard that I almost forgot to report. Copy-pasting so much code as possible from checkouts. When I get it to work similarly then reducing the code gradually.	2.00	Actions
Koha Contributions	07.02.2022 01:34	07.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	Now the task goes forward: I have made the Interlibrary Holds-tab and copied functionality from checkouts	1.00	Actions
Koha Contributions	07.02.2022 00:39	07.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	On the positive side now I now how to implement this task because I have learned a lot about the way these tabs are made	0.50	Actions
Koha Contributions	07.02.2022 00:00	07.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	Ok now I get it. I have to make new tab for interlibrary loans. Wasn't I been stupid!	0.05	Actions
Koha Contributions	06.02.2022 23:57	07.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	Now I realized that there can't be interlibrary holds under holds-tab: it is only for home library holds. That's why there isn't homebranch for that because those holds are always from homebranch	1.00	Actions
Koha Contributions	06.02.2022 23:07	07.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	I guess holds-table oObj is Hold, not Item. Maybe I can reference straight to the Item with Hold-object.	1.00	Actions
Koha Contributions	06.02.2022 22:03	07.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	Studying intensely holds.js	1.00	Actions
Koha Contributions	06.02.2022 15:59	06.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	I have tried to read the code behind KohaTable and dataTable but it is very slow: I'm not very good at Javascript	1.00	Actions
Koha Contributions	06.02.2022 14:55	06.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	I have figured out that the probable reason why item.branch won't work in holds-tab is that the table type is dataTable and checkouts-tab table type is KohaTable	1.00	Actions
Koha Contributions	04.02.2022 05:43	04.02.2022	Samu Heiskanen	Development	Support #776: “Details” under patrons in the staff interface a way to separate ordinary reservations from inter library loan reservations	I only make entry for 3 hours though I worked all night but I didn't finish the job. I learned a lot, but more work tomorrow.	3.00	Actions

Project

General

Profile

Hypernova Oy Redmine

CSV export options