Project

General

Profile

Spent time

Filters

Apply Clear

Hours: 344.53

Created Date User Activity Issue Comment Hours
29.11.2022 13:40 29.11.2022 Lari Taskula Development Support #973: Bug 18595 - Move C4::Members::Messaging to Koha namespace Testing patches, found errors with patch "Catch message preference exceptions in OPAC", wrong exception package name, probably due to previous rebasing mistake. Fixing. 1.00 Actions
28.11.2022 22:30 29.11.2022 Lari Taskula Development Support #993: Bug 32357 - Set borrower_message_preferences.days_in_advance default to NULL Investigating SetMessagingPreferences logic. It seems it overrides borrower_message_preferences.days_in_advance default (from 0 to null), so we might as well set default to null at database level. Implementing patch, figuring out how to test it, commenting on Bugzilla, attaching a patch. 1.50 Actions
10.11.2022 04:57 10.11.2022 Lari Taskula Development Support #973: Bug 18595 - Move C4::Members::Messaging to Koha namespace Rebasing. Git conflicts resolved mostly without pain. There seems to be new appearances of usage of the methods this Bug aims to replace. They have to be identified, replace with the new methods and amend test plan to cover these cases. Identifying all new occurences and replaced them with new methods. Debugging some failed unit tests, especially t/db_dependent/api/v1/patrons.t. Deeper investigation revealed some issues. Firstly, days_in_advance must be explicitly defined as undef, because Koha has defined default days_in_advance value to be 0 at database level. It is easy to explicitly define it but at the same time it is also pointless to do so and such cases should be handled inside Koha objects. Did not yet implement such checks. Secondly, it seems the new objects do not return letter_code and letter_module which are required by the test, and the test will fail with the current logic. Studying what the current options are to resolve this issue. 4.00 Actions
10.11.2022 02:28 10.11.2022 Lari Taskula Development Feature #942: Change item level hold to biblio level hold Rebasing new conflicts 0.50 Actions
03.11.2022 20:53 03.11.2022 Lari Taskula Development Feature #942: Change item level hold to biblio level hold QA failed because patch didn't handle reserves.item_level_hold column. Implementing a fix and unit tests for it, attaching patch to Bugzilla. 0.75 Actions
18.10.2022 23:03 19.10.2022 Lari Taskula Development Feature #942: Change item level hold to biblio level hold Implementing a select dropdown as suggested by a patch tester. Also found a bug in old patches so fixing those. 0.75 Actions
18.10.2022 22:18 19.10.2022 Lari Taskula Development Feature #942: Change item level hold to biblio level hold Reading feedback in Bugzilla, rebasing patches and adding a tooltip. Realizing tooltip/aria-label is wrong when first clicked. Rewording it to "toggle hold type". Changing icon to fa-chain(-broken). Attaching more patches. 2.00 Actions
05.10.2022 16:40 05.10.2022 Lari Taskula Development Feature #942: Change item level hold to biblio level hold Implementing feature. First, approaching functionality from old school CGI scripts but then came into the conclusion that the logic for this feature must be placed into a Koha-object so that it can easily be covered by unit tests. Creating Koha::Hold::change_type and unit tests for the function. Moving on to GUI, stole the red X design from neighbouring columns of existing holds, it looks pretty nice. A hidden input field is placed under the red X, dictating if hold type should be changed in modrequest.pl or not. In order to change that input, some JavaScript was required. Adding a jQuery event listener to holds.js to manipulate input values based on clicks on the red X. Creating a new Bugzilla Bug 31692, documenting issue, writing test plans for the patches and pushing patches to Bugzilla. 8.00 Actions
06.09.2022 21:13 07.09.2022 Lari Taskula Development Feature #942: Change item level hold to biblio level hold Starting to design this feature. Playing with GUI implementation and thinking of how to implement business logic. It is documented that a record cannot have mixed biblio/item level holds - all holds following the first one must be of same type. This places a big restriction on how this feature can be done. Asking client for their ideas. 1.00 Actions
05.07.2022 14:57 05.07.2022 Lari Taskula Development Feature #944: Avoid changing tabs on page reload on holds awaiting pickup page Implementing feature and testing. 2.00 Actions
05.07.2022 14:55 05.07.2022 Lari Taskula Development Feature #941: Bug 22456 - Allow patrons to cancel their waiting holds Testing and revieweing Bug. 2.00 Actions
21.03.2022 10:37 21.03.2022 Lari Taskula Development Support #851: Bug 30200 - Add customizable tabs to interlibrary loan requests list Refactoring. We can use "$.fn.dataTable.ext.search.push" function to filter out unwanted statuses. Tidying up the code and testing. 2.00 Actions
18.03.2022 18:19 18.03.2022 Lari Taskula Development Support #851: Bug 30200 - Add customizable tabs to interlibrary loan requests list Debugging DataTable's column width issue where the width gets messed up once tabs are changed. It seems SQL reports page does not have the same issue. SQL reports is using just one table instead of each table for every tab. Refactoring code. Running into an annoying issue where I cannot safely filter rows by status code because ILL requests DataTable uses the full given names of statuses instead of status codes. 3.00 Actions
03.03.2022 02:54 03.03.2022 Lari Taskula Development Support #851: Bug 30200 - Add customizable tabs to interlibrary loan requests list Developing a first working version. Writing test plans. Pushing patches to Bug 30200. 4.50 Actions
01.03.2022 01:34 01.03.2022 Lari Taskula Development Support #851: Bug 30200 - Add customizable tabs to interlibrary loan requests list Investigating current solutions for customizable tabs. Didn't find anything in system preferences. Thought of placing it in authorized values, but it wouldn't work well there. Adding a new system preference ILLRequestsTabs with a yaml config, writing short documentation for it. 1.00 Actions
22.02.2022 14:27 22.02.2022 Lari Taskula Development Support #762: Edit patron information before registration of arrival Reading an email from Magnus. He had reported a bug on Bug 22321 that I had forgotten. Creating an unit test to cover the bug and implementing a fix. Pushing patches to Bugzilla and reporting back to Magnus. 0.75 Actions
17.02.2022 20:24 16.02.2022 Lari Taskula Development Feature #786: Cron script reminder for unretrieved material Last fixes. illrequests.date_due was not updating so investigating the issue and sending a new commit to PR. 0.50 Actions
15.02.2022 19:48 15.02.2022 Lari Taskula Development Feature #786: Cron script reminder for unretrieved material Making fixes according to Magnus's feedback. Removed faulty logic that message transport types would be based on the messages sent at receival step. Changed it so that now we attempt to find all transport types defined for that specific letter code and send notifications to all of them. Pushing changes to GitHub PR. 1.50 Actions
15.02.2022 13:25 15.02.2022 Lari Taskula Development Support #820: Allow renewals for ILLs Bugfixes. Pushing new commits to PR. 0.50 Actions
14.02.2022 12:10 14.02.2022 Lari Taskula Development Support #840: Don't update borrowernumber if old illrequest exists This was one of the tasks that we requested more information for. Reading Magnus's response to it and looking at the code. It seems we should override $borrower with the pre-existing borrower found in illrequests.borrowernumber if an old illrequests exists. Implementing this and sending a PR to upstream. 0.75 Actions
14.02.2022 11:44 14.02.2022 Lari Taskula Development Support #762: Edit patron information before registration of arrival Designing this feature. It was requested that reserves.borrowernumber should also update when illrequests.borrowernumber is updated. It could be implemented in various ways, but deciding to extend Koha::Illrequest->store() with logic to replace borrowernumber also in reserves-table. Writing unit tests. Reading plenty of DBIx documentation. Figuring out how to retrieve the before-store() value of "borrowernumber" so that it could be compared with the borrowernumber used in "set" (or $illreq->borrowernumber(xxx)), but apprarently it's not possible without fetching the whole Koha-object again (or unless you somehow store it locally in the object). Managed to make it work by fetching the whole object again if borrowernumber is updated according to "get_dirty_columns". Adding an editable input field to ILL-request edit screen and writing a test plan. Pushing patches to Bugzilla. 4.50 Actions
14.02.2022 10:34 14.02.2022 Lari Taskula Development Feature #786: Cron script reminder for unretrieved material Some fixes were required after Magnus's reviewing. Removed useless query, removed a statement that overrided a configuration variable that eventually led into a bug on further iterations of the reminder loop, added some print statements for better logging, and fixed a bug in array size comparison that made the lastly configured letter to be skipped. 1.00 Actions
14.02.2022 07:47 14.02.2022 Lari Taskula Development Support #761: koha-illbackend-libris enhancements Work log entry for Samu's work. Only Lari's entries (such as this) will be billed. Samu debugged a bug with the creation of new ILL request, and after receiving more information from Magnus he fixed it and sent a PR to upstream. 3.75 Actions
14.02.2022 07:41 14.02.2022 Lari Taskula Development Support #820: Allow renewals for ILLs More testing and making bug fixes. Creating a new PR to upstream, ready for review. 0.75 Actions
11.02.2022 16:32 11.02.2022 Lari Taskula Development Support #820: Allow renewals for ILLs Developing this feature. Studying and experimenting how ILL backend statuses behave. It seems that it's enough to create a new placeholder status "IN_UTL_RENEW" that's not an actual status, but just a placeholder to add a button to illview screen. Its actual status (stored in the database) is still "IN_UTL". Using code from the receive step and adjusting it for the needs of renewals. Testing. Pushing changes to GitHub. 3.50 Actions
(26-50/182) Per page: 25, 50, 100, 500

Also available in: Atom CSV