Project

General

Profile

Spent time

Filters

Apply Clear

Hours: 13.50

Created Date User Activity Issue Comment Hours
30.11.2022 18:52 30.11.2022 Lari Taskula Development Support #973: Bug 18595 - Move C4::Members::Messaging to Koha namespace Thinking of possible solutions to the previous issue with missing contact information at patron creation step. First, attempting to catch exceptions at memberentry.pl and display an error message. This doesn't work however due to incompatible error handling in memberentry.pl. Remembered an old solution, a JavaScript validation that I've already implemented before. This could be an approach for resolving the issue. Found my old work from 2015 (Bug 14590) to which we can use here. Restoring old code from the patch in 14590 and rebasing it on current master. Testing changes, seems to work. Continuing testing rest of the test plans, preparing test plans and patches for attaching. 4.00 Actions
30.11.2022 18:24 30.11.2022 Lari Taskula Maintenance Support #973: Bug 18595 - Move C4::Members::Messaging to Koha namespace Going through test plans, found a 500 error in staff client when creating a new patron and email is not set. This was in fact already reported in 18595, but I had forgotten it. Need better exception handling in staff client. 1.00 Actions
29.11.2022 13:40 29.11.2022 Lari Taskula Development Support #973: Bug 18595 - Move C4::Members::Messaging to Koha namespace Testing patches, found errors with patch "Catch message preference exceptions in OPAC", wrong exception package name, probably due to previous rebasing mistake. Fixing. 1.00 Actions
29.11.2022 00:40 29.11.2022 Lari Taskula Maintenance Support #973: Bug 18595 - Move C4::Members::Messaging to Koha namespace Rebasing Bug 18595, fixing tests. 2.00 Actions
28.11.2022 22:30 29.11.2022 Lari Taskula Development Support #993: Bug 32357 - Set borrower_message_preferences.days_in_advance default to NULL Investigating SetMessagingPreferences logic. It seems it overrides borrower_message_preferences.days_in_advance default (from 0 to null), so we might as well set default to null at database level. Implementing patch, figuring out how to test it, commenting on Bugzilla, attaching a patch. 1.50 Actions
10.11.2022 04:57 10.11.2022 Lari Taskula Development Support #973: Bug 18595 - Move C4::Members::Messaging to Koha namespace Rebasing. Git conflicts resolved mostly without pain. There seems to be new appearances of usage of the methods this Bug aims to replace. They have to be identified, replace with the new methods and amend test plan to cover these cases. Identifying all new occurences and replaced them with new methods. Debugging some failed unit tests, especially t/db_dependent/api/v1/patrons.t. Deeper investigation revealed some issues. Firstly, days_in_advance must be explicitly defined as undef, because Koha has defined default days_in_advance value to be 0 at database level. It is easy to explicitly define it but at the same time it is also pointless to do so and such cases should be handled inside Koha objects. Did not yet implement such checks. Secondly, it seems the new objects do not return letter_code and letter_module which are required by the test, and the test will fail with the current logic. Studying what the current options are to resolve this issue. 4.00 Actions
    (1-6/6)

    Also available in: Atom CSV