Spent timehttps://redmine.hypernova.fi/https://redmine.hypernova.fi/favicon.ico?16780521372022-11-10T02:28:10ZHypernova Oy Redmine
Redmine 0.50 hour (Feature #942 (Feedback): Change item level hold to biblio level hold)https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9422022-11-10T02:28:10ZLari Taskula
<p>Rebasing new conflicts</p> 0.25 hour (Feature #942 (Feedback): Change item level hold to biblio level hold)https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9422022-11-04T00:04:41ZLari Taskula
<p>Testing and commenting to Bugzilla.</p> 0.75 hour (Feature #942 (Feedback): Change item level hold to biblio level hold)https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9422022-11-03T20:53:22ZLari Taskula
<p>QA failed because patch didn't handle reserves.item_level_hold column. Implementing a fix and unit tests for it, attaching patch to Bugzilla.</p> 0.25 hour (Feature #942 (Feedback): Change item level hold to biblio level hold)https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9422022-10-26T13:47:01ZLari Taskula
<p>Commenting on Bugzilla</p> 0.50 hour (Feature #942 (Feedback): Change item level hold to biblio level hold)https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9422022-10-24T23:50:31ZLari Taskula
<p>Squashing patches, responding to a comment in Bugzilla, updating test plan.</p> 0.75 hour (Feature #942 (Feedback): Change item level hold to biblio level hold)https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9422022-10-18T23:03:38ZLari Taskula
<p>Implementing a select dropdown as suggested by a patch tester. Also found a bug in old patches so fixing those.</p> 2.00 hours (Feature #942 (Feedback): Change item level hold to biblio level hold)https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9422022-10-18T22:18:53ZLari Taskula
<p>Reading feedback in Bugzilla, rebasing patches and adding a tooltip. Realizing tooltip/aria-label is wrong when first clicked. Rewording it to "toggle hold type". Changing icon to fa-chain(-broken). Attaching more patches.</p> 8.00 hours (Feature #943 (New): Notify librarian of an available item in pickup library when chec...https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9432022-10-18T21:18:41ZLari Taskula
<p>Designing feature. Notifying librarian is quite easy to do. Sketching on what it could look like. A flowchart sent by the client is asking to iterate holds and checking available item at pickup library until no such item is found. It may be out of scope but looking into it anyway. Looks like heavy hold queue logic refactoring would be needed. Reporting findings to the client.</p> 1.00 hour (Feature #940 (Closed): Remove hold to a biblio if a non-holdable itemtype from the sam...https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9402022-10-05T16:50:09ZLari Taskula
<p>Emailing with client, July/August</p> 8.00 hours (Feature #942 (Feedback): Change item level hold to biblio level hold)https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9422022-10-05T16:40:54ZLari Taskula
<p>Implementing feature. First, approaching functionality from old school CGI scripts but then came into the conclusion that the logic for this feature must be placed into a Koha-object so that it can easily be covered by unit tests. Creating Koha::Hold::change_type and unit tests for the function. Moving on to GUI, stole the red X design from neighbouring columns of existing holds, it looks pretty nice. A hidden input field is placed under the red X, dictating if hold type should be changed in modrequest.pl or not. In order to change that input, some JavaScript was required. Adding a jQuery event listener to holds.js to manipulate input values based on clicks on the red X. Creating a new Bugzilla Bug 31692, documenting issue, writing test plans for the patches and pushing patches to Bugzilla.</p> 3.00 hours (Feature #942 (Feedback): Change item level hold to biblio level hold)https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9422022-10-05T16:36:07ZLari Taskula
<p>Design, trying a couple of different solutions in GUI.</p> 1.00 hour (Feature #942 (Feedback): Change item level hold to biblio level hold)https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9422022-09-06T21:13:28ZLari Taskula
<p>Starting to design this feature. Playing with GUI implementation and thinking of how to implement business logic. It is documented that a record cannot have mixed biblio/item level holds - all holds following the first one must be of same type. This places a big restriction on how this feature can be done. Asking client for their ideas.</p> 1.00 hour (Feature #941 (Closed): Bug 22456 - Allow patrons to cancel their waiting holds)https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9412022-07-06T23:30:43ZLari Taskula
<p>Commenting on Bugzilla about a possible scenario where patron wants to revert the cancellation request, had to inspect patches for reference.</p> 1.00 hour (Feature #940 (Closed): Remove hold to a biblio if a non-holdable itemtype from the sam...https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9402022-07-05T18:07:06ZLari Taskula
<p>Going through Finnish Koha libraries' documentation and finding a possible resolution to this issue that requires a change in circulation rules workflow. Instead of defining hold restriction at "Default holds policy by item type", where exissting holds will not cancel when non-holdable itemtype is checked out, to placing the hold restrction at normal circulation rules table, where the holds do cancel when checking out a non-holdable itemtype.</p> 2.00 hours (Feature #944 (Closed): Avoid changing tabs on page reload on holds awaiting pickup page)https://redmine.hypernova.fi/projects/koha-development/time_entries?issue_id=9442022-07-05T14:57:58ZLari Taskula
<p>Implementing feature and testing.</p>